-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix cquery targets filtering #251
fix: Fix cquery targets filtering #251
Conversation
|
bf9aaef
to
c0935fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
c0935fb
to
8dca1b2
Compare
@@ -1,3 +1,11 @@ | |||
@@//src/main/java/com/integration:GuavaUserAndroid.java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's surprising this source file appears here, but it is not filtered out by the starlark function. From my observation, it does have providers:
{"VisibilityProvider": <input file target //src/main/java/com/integration:GuavaUserAndroid.java>, "LicensesProvider": <input file target //src/main/java/com/integration:GuavaUserAndroid.java>, "FileProvider": , "FilesToRunProvider": <unknown object com.google.devtools.build.lib.analysis.FilesToRunProvider$SingleExecutableFilesToRunProvider>}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted that comment in a later commit
Fixes #218
Convert
Build.Target
intoBazelTarget
first before applying the filtering. Doing so will make it easy to filter onname
.Note that e2e tests need to be fixed. Before I go fix those, I wanted to make sure this solution looks good. @tinder-maxwellelliott Please let me know what you think. Thanks.Or maybe a more basic question: is this by design that
cquery
discarding source and generated targets, whichquery
doesn't do?