multi-squares in multi-squares in ... #362
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did this a while ago, but wanted to find a neater solution. Didn't find one and forgot to do it so ill just PR it now if you want to use it.
I did:
Stuff i am not happy with/ is janky:
flattenAndFillDiagramCells
it flattens nested cells and fills the voids.addDiagramCellsToLeftList
it does the same but for rule gen on the left side. Also it returns what structure the nested cell had.addDiagramCellsToRightList
it does the same but for rule gen on the right side and it uses the structure to tell when merge/splitsplitCellToDiagram
function).