-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically create and delete voice channels based on activity #1114
base: develop
Are you sure you want to change the base?
Conversation
This commit aims to add functionality for developers to create their own voice receiver features that deal with events regarding Discord voice channels. It is implemented here since we need to handle such events for the purposes of dynamically creating and deleting voice channels on demand when guild members perform actions involving them, like connecting, disconnecting, or moving between them.
c1296a8
to
51f997f
Compare
51f997f
to
2f14b7d
Compare
I haven't looked at the code yet but I have some suggestions for the functionality.
Importantly, the existing channels should be protected from the changes that get implemented here. This is just an IMO - we should wait for further feedback first. |
This commit slows down the processing of event queues for the sole purpose of preventing Discord API endpoint saturation as well as to avoid the global Discord API Gateway rate limiter. Moreover, it removes a few 'static' keywords that should not be there.
6b9a125
to
ed46d62
Compare
I love @tj-wazei suggestions, we shouldnt delete channels immediately and one more thing to add. We also wanna cap channel count to a certain limit. For example we can't have more than say 3 channels per category for now. We can put this limit in configuration so it's easily tweaked without making changes to code by maintainers. |
Closes #1113.
Media
Configuration changes
dynamicVoiceChannelPatterns