Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/role back message #948

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Bugfix/role back message #948

merged 10 commits into from
Nov 17, 2023

Conversation

ankitsmt211
Copy link
Member

@ankitsmt211 ankitsmt211 commented Nov 12, 2023

  • adds channel pattern for select-your-role in config.java and template
  • method to fetch select-your-role channel
  • replace help-forum with select-your-channel
    resolves get role back message is wrong #946

Release Note

Changes Config, adds:

"selectRolesChannelPattern": "select-your-roles"

@ankitsmt211 ankitsmt211 requested review from a team as code owners November 12, 2023 15:43
@ankitsmt211 ankitsmt211 self-assigned this Nov 12, 2023
Zabuzard
Zabuzard previously approved these changes Nov 13, 2023
@ankitsmt211
Copy link
Member Author

ankitsmt211 commented Nov 16, 2023

added a minor fix for earlier merge, somehow i managed to sneak an if block without curlies(when bugfix contains a bug lol..not exactly a bug but you get the point).

@ankitsmt211 ankitsmt211 merged commit 00e30ba into Together-Java:develop Nov 17, 2023
9 checks passed
@Zabuzard Zabuzard mentioned this pull request Nov 22, 2023
@ankitsmt211 ankitsmt211 deleted the bugfix/role-back-message branch November 30, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get role back message is wrong
3 participants