refactor onModalSubmit in TransferQuestionCommand to handle multiple users submission #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitsmt211
changed the title
Zabuzard
requested changes
Nov 17, 2023
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Nov 18, 2023
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
Zabuzard
approved these changes
Nov 19, 2023
Taz03
approved these changes
Nov 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When multiple users use
transfer-questionfeature at the same time, it can lead to creation of two or more threads in helper forum in rare occasions. To verify this you'd prolly need an alt account to time it correclty.Solution:
Bug fix handles this problem by retrieving the original message that needs to be transferred on submitting the transfer modal,
if it's already transferred then message shouldn't be present.
Implementation:
onModalSubmitchain to a methodtransferFlowfor clarity.handledAlready) to notify user if the transfer was already handled.