Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TJ-bot image #14

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

java-coding-prodigy
Copy link
Contributor

Fixes #13

Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the sizes and resolution dramatically. please scale it down

@Zabuzard Zabuzard added the enhancement New feature or request label Oct 5, 2023
@java-coding-prodigy
Copy link
Contributor Author

Should both the width and height be same or only the width?
Maybe I could also change the css files a bit to accommodate the image?

@Zabuzard
Copy link
Member

Zabuzard commented Oct 6, 2023

  1. if the file is large, the site takes longer to load, google doesnt like that, we get indexed lower
  2. whatever u do, make sure it still looks the same way in the actual website on all resolutions. i could imagine that the website code either doesnt take care of resizing right now, or that it forces a hard resolution anyways

@java-coding-prodigy
Copy link
Contributor Author

I will need to know what device the original image was taken to have the same text wrapping which is needed if the dimensions need to be the same.
It looks like it was taken on a cell phone.

@java-coding-prodigy
Copy link
Contributor Author

I have shrunk the image. The dimensions are nearly the same and the size has been reduced.
However the quality is not as good

@Zabuzard
Copy link
Member

Zabuzard commented Oct 6, 2023

can u share how it looks on the website? full hd and also on a mobile view please

@java-coding-prodigy
Copy link
Contributor Author

can u share how it looks on the website? full hd and also on a mobile view please

How would I host the website tho?

@Zabuzard
Copy link
Member

Zabuzard commented Oct 6, 2023

u can just open it locally in ur browser. double click the html

@Zabuzard Zabuzard merged commit d1be12f into Together-Java:develop Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Bot details on website
2 participants