[blocked] Travis support #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joshua-F
reviewed
Mar 26, 2019
.gitignore
Outdated
| @@ -3,7 +3,6 @@ | |||
| build/ | |||
| out/ | |||
|
|
|||
| gradlew | |||
| gradlew.bat | |||
There was a problem hiding this comment.
Should probably commit gradle.bat also so windows isn't left out with being able to have a gradle wrapper available.
There was a problem hiding this comment.
Fair point! fixing this 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done?
Added a
.travis.ymlto enable travis support.Proposed Changes
Notes
As you can see in the link below the test is failing. This is because the item container test needs the actual cache. @Tomm0017 is working on mocking the tests so it actually works without using a cache 😄.
https://travis-ci.org/DennisSnijder/rsmod/jobs/511200812
blocked by #53