Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting custom TCP receive buffer size #1407

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Conversation

PhilipRoman
Copy link
Collaborator

@PhilipRoman PhilipRoman commented Apr 14, 2024

Description

Add new setter/getter which controls the TCP receive buffer size (previously hardcoded as 16K)

Motivation and Context

This is intended to solve #1406 in a more general way

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

TODO

Before merging this I would like to manually verify that setting the buffer size affects performance as expected
Tested, changing the buffer size affects throughput as expected

Also increase default to 64K for performance improvement.
Copy link
Collaborator

@marci4 marci4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@marci4 marci4 added this to the Release 1.5.7 milestone Apr 27, 2024
@marci4 marci4 merged commit 7e47e4d into master Apr 27, 2024
4 checks passed
@marci4 marci4 deleted the receive-buffer-size branch April 27, 2024 15:04
@Eric-Alvarez
Copy link

@PhilipRoman When is the next release planned? I'm interested in this feature as I've had issues with the current bandwith limitations.

@Vangreen
Copy link

Vangreen commented Jul 3, 2024

@PhilipRoman Same here. We also wait for this release. Any update when release is planned?

@PhilipRoman
Copy link
Collaborator Author

@marci4

@marci4
Copy link
Collaborator

marci4 commented Jul 3, 2024

#1430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants