Fix: use aref when fieldmapping is empty #2
Conversation
rhouthuijzen
added
the
needs-review
| @@ -33,6 +33,7 @@ The following lifecycle actions are available: | |||
| | Action | Description | | |||
| | ------------------ | ------------------------------------ | | |||
| | create.ps1 | PowerShell _create_ lifecycle action | | |||
| | update.ps1 | PowerShell _update_ lifecycle action | | |||
There was a problem hiding this comment.
I think it would be good to describe the actions you're executing in each script. Especially since the create and update scripts only do correlation. I know we have a bit disclaimer describing this, but it wouldn't hurt to repeat that message?
| $outputContext.AccountReference = $actionContext.Data.EmailAddress | ||
| } | ||
| $outputContext.success = $true | ||
| $outputContext.AuditLogs.Add([PSCustomObject]@{ |
There was a problem hiding this comment.
Do we want to do something with previousData so the audit message is only shown when previousdata != data?
| @@ -44,16 +44,22 @@ try { | |||
| throw 'The account reference could not be found' | |||
There was a problem hiding this comment.
in the readme, you say: 'The $actionContext.References.Account is used when $actionContext.Data.EmailAddress is empty in the delete lifecycle action.' and in the mapping the aRef is will empty when there's no emailaddress. If there's a situation where the emailaddress is empty in aRef, the script will fail here, instead of getting the emailaddress from the mapping. The chance that this occurs is very slim, but i do think we should fix this.
I think we can fix this by throwing an error only when aRef and Data.EmailAddress are empty.
| } | ||
| $outputContext.success = $true | ||
| $outputContext.AuditLogs.Add([PSCustomObject]@{ | ||
| Action = 'CorrelateAccount' |
There was a problem hiding this comment.
We also say we correlate while Data.Emailaddress is empty?
There was a problem hiding this comment.
i think these comments apply to the create script too
No description provided.