Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(socketio/socket): create a different socket id for each ns #123

Merged
merged 1 commit into from
Oct 21, 2023
Merged

fix(socketio/socket): create a different socket id for each ns #123

merged 1 commit into from
Oct 21, 2023

Conversation

Totodore
Copy link
Owner

This PR fix #117 by creating a different socket id for each new namespace socket for the socketio v5 protocol.

@Totodore Totodore added bug Something isn't working socketio-v5 It is only about the version 5 of the socket.io protocol labels Oct 20, 2023
@Totodore Totodore merged commit 0f9e0c1 into main Oct 21, 2023
8 checks passed
@Totodore Totodore deleted the fix-different-sid-for-socketio-ns branch October 21, 2023 00:05
@Totodore Totodore mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working socketio-v5 It is only about the version 5 of the socket.io protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send a socket id different from the engine socket id for each namespace
1 participant
@Totodore