-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: move to a Boxed Adapter #324
Draft
Totodore
wants to merge
26
commits into
main
Choose a base branch
from
ft-boxed-adapter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totodore
force-pushed
the
ft-boxed-adapter
branch
from
May 24, 2024 15:41
919ca81
to
36654c1
Compare
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Totodore
force-pushed
the
ft-boxed-adapter
branch
from
May 28, 2024 14:26
36654c1
to
be39216
Compare
Totodore
force-pushed
the
ft-boxed-adapter
branch
from
May 28, 2024 14:31
be39216
to
e97a198
Compare
Totodore
force-pushed
the
ft-boxed-adapter
branch
from
June 21, 2024 07:37
e97a198
to
9402687
Compare
Totodore
force-pushed
the
ft-boxed-adapter
branch
from
June 21, 2024 07:38
9402687
to
afed9fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a boxed adapter would allow to remove the generic
Adapter
from every types in the socketioxide codebase.