9H to configure channels doesn't work on d4k-3ch or other lights that use custom 3H functions #107
Comments
fwiffo
added a commit
to fwiffo/anduril
that referenced
this issue
Sep 29, 2024
If a light has a custom 3H function specified for a channel, it would always call the custom function, not just during 3H events. It would only return if the event was handled by the custom function, but would fall out of the if/else otherwise, preventing later events from being handled. This prevented access to the 9H channel config in HSV mode, for instance.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
If a light has a custom 3H function specified for a channel, it would always call the custom function, not just during 3H events. It would only return if the event was handled by the custom function, but would fall out of the if/else otherwise, preventing later events from being handled. This prevented access to the 9H channel config in HSV mode, for instance.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
If a light has a custom 3H function specified for a channel, it would always call the custom function, not just during 3H events. It would only return if the event was handled by the custom function, but would fall out of the if/else otherwise, preventing later events from being handled. This prevented access to the 9H channel config in HSV mode, for instance.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
If a light has a custom 3H function specified for a channel, it would always call the custom function, not just during 3H events. It would only return if the event was handled by the custom function, but would fall out of the if/else otherwise, preventing later events from being handled. This prevented access to the 9H channel config in HSV mode, for instance.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
If a light has a custom 3H function specified for a channel, it would always call the custom function, not just during 3H events. It would only return if the event was handled by the custom function, but would fall out of the if/else otherwise, preventing later events from being handled. This prevented access to the 9H channel config in HSV mode, for instance.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
If a light has a custom 3H function specified for a channel, it would always call the custom function, not just during 3H events. It would only return if the event was handled by the custom function, but would fall out of the if/else otherwise, preventing later events from being handled. This prevented access to the 9H channel config in HSV mode, for instance.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
If a light has a custom 3H function specified for a channel, it would always call the custom function, not just during 3H events. It would only return if the event was handled by the custom function, but would fall out of the if/else otherwise, preventing later events from being handled. This prevented access to the 9H channel config in HSV mode, for instance.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 14, 2024
If a light has a custom 3H function specified for a channel, it would always call the custom function, not just during 3H events. It would only return if the event was handled by the custom function, but would fall out of the if/else otherwise, preventing later events from being handled. This prevented access to the 9H channel config in HSV mode, for instance.
Isilmerie
pushed a commit
to Isilmerie/anduril
that referenced
this issue
Oct 16, 2024
If a light has a custom 3H function specified for a channel, it would always call the custom function, not just during 3H events. It would only return if the event was handled by the custom function, but would fall out of the if/else otherwise, preventing later events from being handled. This prevented access to the 9H channel config in HSV mode, for instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Events that come after 3H aren't handled in channel-modes.c because it falls out of the if/else if/else if/etc. if there is a custom 3H function, even though it only returns if the custom function returns EVENT_HANDLED. This prevents 9H to configure channels from working on the d4k-3ch in HSV mode.
I have a fix and will send a PR.
The text was updated successfully, but these errors were encountered: