Fix custom ch fallthrough #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configures the assumed temperature (default 21C) when performing thermal autocalibration during a factory reset.
Allows jump-start to only apply to channels that actually need to be enabled to avoid an unnecessary flash when entering moonlight mode when only one channel is on.
This was the behavior in older versions.
This is doing something weird not intended.
Allows tuning different brightness levels to specific color temperatures.
The fix for ToyKeeper#85 moved the strobe mode event in off-mode.c inside an ifdef USE_SIMPLE_UI block where they did not belong. Moving them below that block fixes ToyKeeper#94.
If a light has a custom 3H function specified for a channel, it would always call the custom function, not just during 3H events. It would only return if the event was handled by the custom function, but would fall out of the if/else otherwise, preventing later events from being handled. This prevented access to the 9H channel config in HSV modeon the d4k-3ch, for instance.
|
Sigh, I don't know how to make branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #107 by only using the custom 3H function for 3H events.