Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a d3aa firmware variant with jumpstart, and fix a bug where channel mode config could be accessed from off if globals config was not enabled #100

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

SiteRelEnby
Copy link
Contributor

@SiteRelEnby SiteRelEnby commented Sep 11, 2024

Fixes #99

@SammysHP
Copy link
Contributor

What about other modes like lockout? Handling 9H in a global "super" state might be too much if we want it only in "on". I'd even say it should be available only in the ramping state, because it doesn't make much sense in e.g. battery check or a strobe mode.

@dirtydancing
Copy link

I'd even say it should be available only in the ramping state

Agreed. And so far, I have only ever seen references to 9H from On for channel mode config. I am not sure that it is widely known at all that 9H for channel mode config is presently also accessible from Lockout (and from Off, if there is no misc/globals config).

@SiteRelEnby
Copy link
Contributor Author

SiteRelEnby commented Sep 11, 2024

Yeah, good catch, probably better to just use a check for if state == steady_state on the event.

Edit: Done.

@SiteRelEnby SiteRelEnby force-pushed the issue99-d3aa-jumpstart branch 3 times, most recently from 0c37b74 to ffcfcdb Compare September 11, 2024 21:39
…annel mode config could be accessed from off if globals config was not enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

D3AA emitter specific ramping issue (SST-20 deep red)
3 participants