-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved three-channel interface and 3-channel strobes #114
base: trunk
Are you sure you want to change the base?
Commits on Sep 29, 2024
-
Reorganizes channels for 3-channel Emisar D4K.
The first 7 channels now follow the same sequence as AUX LEDs. I.e. if the channels were red, green, and blue, the sequence would be red, yellow, green, cyan, blue, magenta, and white. The remaining channels are HSV, 3-channel auto-tint, and RGB AUX. Removes the 2-channel tintramp modes since there is a limit of 16 channels and HSV mode covers those combinations with a more general interface. Next step will be adding explict control for saturation so that all possible 3-channel combinations will be explicitly possible in HSV mode.
Configuration menu - View commit details
-
Copy full SHA for c497041 - Browse repository at this point
Copy the full SHA c497041View commit details -
Add "secondary" channel mode args that are ramped with 4H.
This allows for a "saturation" parameter in HSV modes on 3-channel lights. This uses 4H, thus removing momentary turbo from channels that require a second channel arg. This is a silly way to implement it; it would be nice to be more generic and allow for some struct or arbitrary number of channel args or something, but how many lights need more than 2 channel args, and you'd need to do something like 23H to manage it all.
Configuration menu - View commit details
-
Copy full SHA for 1ee534b - Browse repository at this point
Copy the full SHA 1ee534bView commit details -
Fix bug blocking channel-mode events past 3H on d4k-3ch.
If a light has a custom 3H function specified for a channel, it would always call the custom function, not just during 3H events. It would only return if the event was handled by the custom function, but would fall out of the if/else otherwise, preventing later events from being handled. This prevented access to the 9H channel config in HSV mode, for instance.
Configuration menu - View commit details
-
Copy full SHA for e37b28f - Browse repository at this point
Copy the full SHA e37b28fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7c3c67 - Browse repository at this point
Copy the full SHA d7c3c67View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8fe0e4 - Browse repository at this point
Copy the full SHA a8fe0e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81454ec - Browse repository at this point
Copy the full SHA 81454ecView commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c63d508 - Browse repository at this point
Copy the full SHA c63d508View commit details -
Fix flickering when adjusting saturation in rainbow mode.
Instead of bracketing the set_level() with saving/restoring the existing channel_args, it instead puts them around save_config() calls. This feels brittle, but an alternative - exposing a function that bypasses set_level() to set HSV more directly - also feels brittle.
Configuration menu - View commit details
-
Copy full SHA for 22f0022 - Browse repository at this point
Copy the full SHA 22f0022View commit details -
Allow adjusting speed of rainbow mode with 3H.
Brightness is still adjusted with 1H and 2H as with other modes, and saturation is still available with 4H as it is in regular ramp mode on the HSV channel.
Configuration menu - View commit details
-
Copy full SHA for 2852272 - Browse repository at this point
Copy the full SHA 2852272View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c2b7a8 - Browse repository at this point
Copy the full SHA 7c2b7a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fd82ef - Browse repository at this point
Copy the full SHA 2fd82efView commit details