Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate tt utils modules to core #4

Merged
merged 18 commits into from
May 9, 2024

Conversation

MinHtet-O
Copy link
Contributor

@MinHtet-O MinHtet-O commented May 2, 2024

Summary

What is the background of this pull request?

migrate all the functions from TradeTrust-utils into TradeTrust-core library

Changes

  • What are the changes made in this pull request?

  • Migrate analytics (google analytics)

  • Migrate constants

  • Migrate static icons

  • Replace ganache with hardhat to setup local blockchain as ganache is archived

  • Migrate generateProvider method from tt-verify

Issues

What are the related issues or stories?

https://tradetrust.atlassian.net/browse/TT-99

@MinHtet-O MinHtet-O requested a review from rongquan1 May 2, 2024 01:46
@MinHtet-O MinHtet-O force-pushed the fix/tt-99-migrate-utils-to-core branch from 766d6ae to 3fb018b Compare May 2, 2024 01:48
gaPageView(
{
action: 'TEST_ACTION',
} as any,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

})

it('does not fail if gtag is not present', () => {
gaEvent(mockGaEvent as any)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.

@MinHtet-O MinHtet-O force-pushed the fix/tt-99-migrate-utils-to-core branch 12 times, most recently from 00ab322 to 1391261 Compare May 7, 2024 01:42
@MinHtet-O MinHtet-O force-pushed the fix/tt-99-migrate-utils-to-core branch 6 times, most recently from 061e69a to 1cd4a51 Compare May 8, 2024 06:20
@MinHtet-O MinHtet-O force-pushed the fix/tt-99-migrate-utils-to-core branch 3 times, most recently from af901f9 to 2508808 Compare May 8, 2024 10:23
@MinHtet-O MinHtet-O force-pushed the fix/tt-99-migrate-utils-to-core branch 7 times, most recently from af06cbe to 05d1c5c Compare May 9, 2024 02:06
@MinHtet-O MinHtet-O force-pushed the fix/tt-99-migrate-utils-to-core branch 4 times, most recently from 0a86f26 to 99dd28c Compare May 9, 2024 02:23
@MinHtet-O MinHtet-O force-pushed the fix/tt-99-migrate-utils-to-core branch 2 times, most recently from 8eff47d to ef74752 Compare May 9, 2024 02:57
@MinHtet-O MinHtet-O force-pushed the fix/tt-99-migrate-utils-to-core branch from ef74752 to c5c42ba Compare May 9, 2024 03:26
@MinHtet-O MinHtet-O force-pushed the fix/tt-99-migrate-utils-to-core branch from f4f7d7d to bfcde1b Compare May 9, 2024 05:17
@MinHtet-O MinHtet-O force-pushed the fix/tt-99-migrate-utils-to-core branch from bfcde1b to d397b36 Compare May 9, 2024 05:19
@MinHtet-O MinHtet-O merged commit 1b3aa0f into v2.0.0 May 9, 2024
5 checks passed
@MinHtet-O MinHtet-O deleted the fix/tt-99-migrate-utils-to-core branch May 9, 2024 05:34
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants