Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: alchemy keys #801

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: alchemy keys #801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/config/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ module.exports = {
},
INFURA_API_KEY: process.env.INFURA_API_KEY || "bb46da3f80e040e8ab73c0a9ff365d18",
INFURA_PROJECT_ID: "1f1ff2b3fca04f8d99f67d465c59e4ef",
ALCHEMY_API_KEY: process.env.ALCHEMY_API_KEY || "pV9JmoYcDFFBihXlJWt6FSDxzNAVWxdT",
ALCHEMY_API_KEY: process.env.ALCHEMY_API_KEY || "483Uqp_0SP0NnXI0secbJgrSRXv4OXaj",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious only, is any part of our frontend now uses the Alchemy API key instead of the Infura one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none at all. i can only assume it was to help those **.integration.test.ts tests be more stable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any concerns?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinions about it, though, I’d be curious if there is a reason for using Alchemy for integration testing only but Infura for the actual functionalities?

IS_DEVELOPMENT,
IS_MAINNET,
MAGIC_API_KEY: process.env.MAGIC_API_KEY || process.env.MAGIC_API_KEY_FALLBACK || "pk_test_AB1F885AF848182E", // dlt gmail fallback
Expand Down
5 changes: 2 additions & 3 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,11 @@ module.exports = {
plugins: [
new webpack.IgnorePlugin(/magic-sdk$/), // HOT FIX (Temp removal of magic demo until we might decide to kill it)
new webpack.EnvironmentPlugin({
// need to define variables here, so later can be overwritten at netlify env var end
// TODO: use dotenv instead
NODE_ENV: "development",
NET: "sepolia",
INFURA_API_KEY: "bb46da3f80e040e8ab73c0a9ff365d18",
}),
ALCHEMY_API_KEY: "483Uqp_0SP0NnXI0secbJgrSRXv4OXaj",
}), // fallbacks for each respective env, if not defined at netlify end
new HtmlWebpackPlugin({
filename: "index.html",
template: `${__dirname}/public/static/index.html`,
Expand Down
Loading