Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable BlockNumber for View endorsement chain #921

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

satz07
Copy link
Contributor

@satz07 satz07 commented Jun 14, 2024

Summary

What is the background of this pull request?
Change the from block number logic so that TradeTrust starts fetching from the block number when it was integrated into the XDC Network, instead from the genesis block. This will ensure faster and efficient responses.

Changes

  • Added blockNumber field to chain info. It is an optional parameter for any chains to use.
  • Updated the functions to use this blockNumber instead from the genesis block to query
  • Updated the Integration tests with additional parameter
image

Issues

View endorsement chain during verification of document fails as it requires archival node to fetch complete history and fetches data from genesis block

Copy link

netlify bot commented Jun 14, 2024

👷 Deploy request for tradetrust-beta pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit aa55485

Copy link

netlify bot commented Jun 14, 2024

👷 Deploy request for reference-implementation pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit aa55485

@MinHtet-O
Copy link
Contributor

Hi @satz07,

We are currently benchmarking and seeking opportunities to improve our view endorsement chain.
xdc-inconsistent
However, I am encountering inconsistent delays, way longer than usual, in some operations using the RPC URL provided by the XDC team. These inconsistencies make it difficult to compare the overall durations of the view endorsement chain before and after optimizations. Could the XDC team assist us by providing a stable RPC URL?

@MinHtet-O
Copy link
Contributor

MinHtet-O commented Jul 18, 2024

Regarding the changes in querying the blockchain starting from a specific block number, may I know in detail how much the view endorsement chain process on XDC improves? We need to determine if the cost of changing the code and adding extra complexity outweighs the efficiency gains. When I tested it on Sepolia, I did not see significant improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants