Hotfix/write array command #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Array parameter in 'write' method surely needs to be fixed! Not possible to run queries in requests |
Trakkasure
reviewed
Dec 27, 2018
| @@ -55,5 +55,9 @@ | |||
| "main": "dist/mikronode.js", | |||
| "engines": { | |||
| "node": ">= 6" | |||
| }, | |||
| "dependencies": { | |||
| "pegjs": "^0.10.0", | |||
There was a problem hiding this comment.
pegjs should be devDependencies
Promise is not required since it is available natively in NodeJs
Trakkasure
reviewed
Dec 27, 2018
| @@ -359,7 +359,7 @@ export default class Channel extends events.EventEmitter { | |||
| } else return o; | |||
| },{}) | |||
|
|
|||
| const isListen=command.split('/').indexOf('listen')>0; | |||
| const isListen= typeof command === 'object' ? command.indexOf('listen')>0 : command.split('/').indexOf('listen')>0; | |||
There was a problem hiding this comment.
(Array.isArray(command)?command:command.split('/')).indexOf('listend')>0
Trakkasure
reviewed
Dec 27, 2018
| @@ -17,7 +17,7 @@ data | |||
| = id:identifier value:value s { return {field:id, value:value}} | |||
|
|
|||
| identifier | |||
| = "=" id:[\.a-zA-Z\-0-9]+ "=" {return id.join('')} | |||
| = "=" id:[\.a-zA-Z\-0-9\/]+ "=" {return id.join('')} | |||
There was a problem hiding this comment.
Should '/' be allowed as part of an ID? Could :, |, ;, _, or - be used just as effectively? Didn't want to cause issues when doing splits and regular expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed handling of first parameter being a type of array of strings in
channel.write.Added allowance for forward slashes in field values grep.