🦹♂️ Add missing functions to set minimum OS and GPU targets on IRCompiler
#23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting the minimum targets that emitted Metal shaders should support, we may not only be opting out of potential optimizations that are only supported on newer OS versions or GPUs (i.e. per the feature tables at) https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf) but also receive adequate errors when features used in shaders are not supported by the given minimum target, such as:
(This happens when setting the deployment target to MacOS 13, as texture atomics are only supported on MacOS 14 onwards)
Unfortunately the compiler also throws a related error on one of our shaders regardless of the deployment target we set, as if there's a (broken) requirement to not set
minimumDeploymentTarget
higher than the machine thatmetal_irconverter
is running on?