Total hit counts added #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To align with the rust files, I had to re-add the missing RNAs.fasta file to the fixtures directory and update the filename in the python count script from RNAseqs.fasta to RNAs.fasta.
Super naive implementation of feature to report total hit counts added. For each search result reported, it now also prints out the running total of hits for each DCE. This is accomplished by adding a "hits" field to the CompressedSeq struct, making the needle mutable, and incrementing its hits number every time there is a match while searching. Adaptations are still required to create results matching the python version, i.e. writing out to a results file that contains the name of each DCE that had >= 1 hit, and the total number of hits it had.
glesica
reviewed
May 21, 2020
| if needle.sequence == self.haystack_window { | ||
| needle.hits = needle.hits+1; |
There was a problem hiding this comment.
Suggested change
| needle.hits = needle.hits+1; | |
| needle.hits += 1; |
glesica
reviewed
May 21, 2020
| @@ -7,6 +7,7 @@ pub struct Seq { | |||
| pub identifier: String, | |||
| pub length: usize, | |||
| pub sequence: Vec<char>, | |||
| pub hits: u64, | |||
There was a problem hiding this comment.
Does Seq actually need this? The DNA sequences are all stored as CompressedSeqs.
This is a "functioning" version with the input arguments and print to file features added, but it is incredibly slow and total hits count doesn't work properly with the way main iterates through the sequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.