Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the browser make detection code to work with IE11 that reports it... #323

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Cakefile
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ task 'deps', 'Write out dependency file for running in non-compiled mode', ->

task 'size', 'Display file sizes', (options) ->
# Nothing to do if no build directory
return if not path.existsSync build_dir
return if not fs.existsSync build_dir

sizes = {}
maxFileLength = 0
Expand Down Expand Up @@ -187,7 +187,7 @@ createDirs = ->

# Remove directory and its contents
rmdirTreeSync = (dir) ->
return if not path.existsSync dir
return if not fs.existsSync dir
console.log "Removing: #{dir}"

fs.readdirSync(dir).forEach (f) ->
Expand All @@ -201,7 +201,7 @@ rmdirTreeSync = (dir) ->

# Recursively fetch all files within a directory
getFilesSync = (dir, match, exclude) ->
return [] if not path.existsSync dir
return [] if not fs.existsSync dir

files = []

Expand Down Expand Up @@ -332,7 +332,7 @@ getCompiledScript = (info, options, callback) ->
args += " --define='goog.DEBUG=false'"

# Externs
if path.existsSync externs_dir
if fs.existsSync externs_dir
fs.readdirSync(externs_dir).forEach (f) ->
args += " --externs=#{path.join externs_dir, f}"

Expand Down
7 changes: 6 additions & 1 deletion src/lib/capabilities.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,12 @@ goog.scope(function() {
}
else if (!/compatible/.test(capabilities.ua_) &&
/mozilla/.test(capabilities.ua_)) {
return 'mozilla';
if (/trident/.test(capabilities.ua_)) {
return 'msie';
}
else {
return 'mozilla';
}
}
else {
return 'unknown';
Expand Down
2 changes: 1 addition & 1 deletion src/ui/articlemanager.js
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,7 @@ goog.scope(function() {
events.fireEvent(document, ArticleManager.events.DOCUMENTCHANGED, {
'document': doc,
'url': url,
'path': path
'docpath': path
});
events.fireEvent(document, ArticleManager.events.ARTICLECHANGED, {
'article': ArticleManager.currentArticle
Expand Down