Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unit type support #74

Merged
merged 2 commits into from
Nov 11, 2023
Merged

feat: unit type support #74

merged 2 commits into from
Nov 11, 2023

Conversation

Abdulsametileri
Copy link
Member

@Abdulsametileri Abdulsametileri commented Nov 11, 2023 •
edited
Loading

I choice this PR instead of it because of merge conflicts

@Abdulsametileri Abdulsametileri changed the title Feature/unit type support feat: unit type support Nov 11, 2023
mhmtszr
mhmtszr approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@mhmtszr mhmtszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Abdulsametileri Abdulsametileri merged commit 800c885 into master Nov 11, 2023
2 checks passed
@Abdulsametileri Abdulsametileri deleted the feature/unit-type-support branch November 11, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmtszr mhmtszr mhmtszr approved these changes

@erayarslan erayarslan Awaiting requested review from erayarslan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abdulsametileri @mhmtszr