Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANTA-4627 https://jira.joyent.us/browse/MANTA-4627 #12

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Conversation

isaacdavis
Copy link
Contributor

@isaacdavis isaacdavis commented Oct 22, 2019

Opening this now, even though I don't really have the means to test it yet.

What would people like to see for testing?

Note that this is a major version update, to 0.2.0.

Copy link

@kellymclaughlin kellymclaughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The basic_test module needs to be updated as well for this change.

@kellymclaughlin
Copy link

What would people like to see for testing?

There are some basic tests already, but those probably need to be expanded. I think there's also some more interesting testing we can and should do. Maybe we can start another issue and brainstorm some testing ideas?

@isaacdavis
Copy link
Contributor Author

Ok, I've at least made the basic tests compile and pass:

[isaac@lullabuild-19 ~/git-sand/rust-cueball]$ cargo test
    Finished dev [unoptimized + debuginfo] target(s) in 1.62s
     Running target/debug/deps/cueball-863fbb5d86a8e62c

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/basic_test-4464f3ba0e4fbbcf

running 4 tests
test connection_pool_stop ... ok
test connection_pool_accounting ... ok
test connection_pool_claim ... ok
test connection_pool_decoherence ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests cueball

running 2 tests
test src/lib.rs -  (line 136) ... ignored
test src/lib.rs -  (line 40) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out

@isaacdavis
Copy link
Contributor Author

Opened #13 for brainstorming testing ideas.

@isaacdavis isaacdavis merged commit aaed4a3 into master Oct 25, 2019
@kellymclaughlin kellymclaughlin deleted the MANTA-4627 branch October 25, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants