Feature/kevinkatelyn/our mission page #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackavh
reviewed
Feb 17, 2024
There was a problem hiding this comment.
Hi guys, the page looks great overall! I have one really minor note,
- It could be something on my end, but the BackgroundHeader
looks a little bright to me. I think on Figma there's a slight grey overlay, if it's not something weird with my computer it would be an easy style fix in the div wrapping the image.
Good work! Abstracting valueCard and Button makes the page code easy to read. Lmk what you think!
jennymar
approved these changes
Feb 23, 2024
frontend/public/threepeople.png
Outdated
There was a problem hiding this comment.
let's use svgs instead of pngs to maintain resolution on the page!
|
|
||
| .description { | ||
| text-align: left; | ||
| font-family: "Open Sans"; |
There was a problem hiding this comment.
you can use font-family: var(--font-body); for the open sans font and font-family: var(--font-small-subtitle); for the roboto slab font!
frontend/src/components/Button.tsx
Outdated
There was a problem hiding this comment.
thanks for making a Button component!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #11
Changes
We created the Our Mission page. In the frontend, we created a Value Card component. We also made a Button component for the Our Team button that redirects to the Our Team page.
Testing
We visually compared the website with the Figma to ensure they match, and we ensured that everything wrapped as expected when resizing the window.
Confirmation of Change