Feaure/sidhantrohatgi/prescreeningquestions #32
Conversation
Changed the Prescreening tsx Added CSS for Text
Changed Submit button to use the default button with the Button component's CSS.
sidhantrohatgi
changed the title
| 1. Please select the appropriate amount of experience you currently have. | ||
| </p> | ||
|
|
||
| <br></br> |
There was a problem hiding this comment.
Lets do self closing tags so <br /> for this one and all other <br> tags
|
|
||
| const navigate = useNavigate(); | ||
|
|
||
| const handleFormSubmit = (e: React.FormEvent<HTMLFormElement>) => { |
There was a problem hiding this comment.
Pull the code from main. Hrithik changes in button should work. The function would be
const handleFormSubmit = () => { ....} and the e.preventDefault(); won't be needed
Lets try to keep it consistent and just use our own button component
There was a problem hiding this comment.
This file should be in the pages folder not the components folder
| ); | ||
| } | ||
|
|
||
| export default PrescreeningForm; |
There was a problem hiding this comment.
We don't need this line here. We exported the function before and the convention in this project is to not use export default
frontend/src/components/index.ts
Outdated
| @@ -5,5 +5,6 @@ import { NavBar } from "./NavBar.tsx"; | |||
| import { Page } from "./Page.tsx"; | |||
| import { Pathway } from "./Pathway.tsx"; | |||
| import { PathwayTimeline } from "./PathwayTimeline.tsx"; | |||
| import { PrescreeningForm } from "./PrescreeningForm.tsx"; | |||
There was a problem hiding this comment.
This import should be in the index.ts file in the pages folder after you moved the files
|
|
||
| <div className={styles.centeredContainer}> | ||
| <button className={buttonStyle.button} type="submit" form="form1" value="Submit"> | ||
| Submit |
There was a problem hiding this comment.
Figma has this as continue instead of submit. Let's follow the figma
| @@ -72,7 +72,7 @@ export function NavBar() { | |||
| </a> | |||
| </li> | |||
| <li> | |||
| <NavLink className={styles.navLink} to={"/apply"}> | |||
| <NavLink className={styles.navLink} to={"/prescreening"}> | |||
| <Button onClick={null}>Apply</Button> | |||
There was a problem hiding this comment.
There are also a few buttons on the home page here and here to update.
You can either use the useNavigate method you did in the handleSubmit or the window.location.href way used in the Congradulations popup
| {/* Question 1 */} | ||
| <div> |
There was a problem hiding this comment.
Each question is in div container. Label the div container and add more spacing between each question (marging top/bottom). Questions are a little too close to each other compared to Figma.
|
|
||
| <label htmlFor="op11" className={styles.label}> | ||
| <p> | ||
| 5+ years of Diversified Design Experience <strong> and/or </strong> 40+ Core Units |
There was a problem hiding this comment.
There is missing indentation for the radio points.
Tracking Info
Resolves #8
Changes
Implemented front end for the prescreening questions page (Page accessible by clicking on Apply in the Nav Bar)
Testing
Confirmation of Change
Page:
Page with selected options:
Redirected to this page according to the user's answers: