Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contexts for step1 and step4 #60

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

contexts for step1 and step4 #60

wants to merge 5 commits into from

Conversation

kathyychenn
Copy link
Contributor

Tracking Info

Resolves #40

Changes

Update step1 and step4 to store inputs to formContext

Testing

  • TODO

Confirmation of Change

@kathyychenn kathyychenn linked an issue May 21, 2024 that may be closed by this pull request
Step 4: connect to the context #42
Open
Miyuki-L
Miyuki-L approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@Miyuki-L Miyuki-L left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a value name change and console log to remove. After reviewing the keyboard dropdown interactivity PR see if make sure its changes to the Dropdown components still works with the form context.

frontend/src/components/Step4.tsx Show resolved Hide resolved
frontend/src/components/Step4.tsx Outdated Show resolved Hide resolved
@Miyuki-L Miyuki-L requested a review from hpai1 June 4, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miyuki-L Miyuki-L Miyuki-L approved these changes

@hpai1 hpai1 Awaiting requested review from hpai1

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Step 4: connect to the context Step 1: Update Context
2 participants
@kathyychenn @Miyuki-L