added contactRequests #21
Open
+149
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I came across a few issues. I would prefer that each of our request handlers can propagate to the next function to effectively leverage the error handler. Please add a Also, there's no need to create a separate promise called Also can you make sure to add the app password since I got the error |
|
Updated .env variables to include email and email app password for contact request |
mraysu
previously approved these changes
Jan 16, 2025
westonz7042
dismissed stale reviews from PoliteUnicorn and mraysu
via
cf835be
mraysu
reviewed
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4
Added POST api/contact route, as well as handler and validator for contact requests. Created error file for contacts and updated backend .env with testing email + app password for nodemailer.
Tested with sample contact request in postman - console logged successfully and email was sent by the homework email to the homework email (as intended).