Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sydney vsr table staff view #26

Merged
merged 39 commits into from
Mar 4, 2024
Merged

Feature/sydney vsr table staff view #26

merged 39 commits into from
Mar 4, 2024

Conversation

sydneyzhang18
Copy link
Contributor

Tracking Info

Resolves #10

Changes

  • Created frontend on /staff/vsr
  • Wrote backend GET route to get all VSRs

Testing

  • Started frontend and viewed page
  • Manually tested GET request in terminal

Confirmation of Change

  • Start frontend and backend
  • Go to http://localhost:3000/staff/vsr and view frontend w/ header, title, and table
  • After changes, should be able to see all VSRs in mongo on the table, manually add a VSR, and see the updated VSRs on table

TODO

  • Populate frontend with non-hard coded VSRs from mongo
  • Frontend: alignment of "Service Requests" header, font, color of checkbox in header row

2s2e and others added 30 commits January 18, 2024 16:53
@2s2e
lint fixes
2e91d71
@yotzkim
Added route to POST and VSR controller
2882ed1
@2s2e
Added validation functions for form responses
bd86e86
@2s2e
Added validation functions for form responses
c5f9be6
@2s2e
Removed numOfBoys, numOfGirls from schema, cleaned up backend, rename…
191d148 
…d martial to marital
@2s2e
Added tests for validate spouse name
b962925
@2s2e
Added tests for validate ethnicity
4bbf60c
@yotzkim
Basic text field, multiple choice, dropdown, and submit
9c8791b
@yotzkim
Fix linting issues and minor edit to gender field validation
ae56430
@yotzkim
Basic components
713a852
@2s2e
app now uses post route
aa064e2
@2s2e
Attempt at linking front end with back end, onbooarding code for fron…
1cf38cf 
…t end api requests imported and adjusted
@2s2e
Reworked TextField component to do ref-forwarding, successfully pushe…
ef8da1c 
…d a document to the mongo database
@sydneyzhang18
created major components, missing details and dropdown
afe939e
@2s2e
Fixed couple bugs with date verification
e84c5a0
@yotzkim
Removed forwardRef
9ea7802
@yotzkim
Resolved merge conflicts between local and remote branches.
bb4e877
@sydneyzhang18
adjusting table styling
3455044
@yotzkim
Added title and description, required fields, and overall more styling
9dc911b
@2s2e
updated date to use current date, added more fields for the vsr page
3a36749
@2s2e
Prototype of ethnicity selector
5c4f986
@2s2e
Made options unselectable
361c880
@2s2e
Working version of ethnicity form
c7a9650
@2s2e
Prototype of appearing and disappearing children form
d14e4bb
@yotzkim
Added more styling
21f6579
@yotzkim
Added more styling
8a8a6f5
@sydneyzhang18
adjusting alignment
4444501
@sydneyzhang18
Merge branch 'feature/steven+yoto-vsr-personal-info' into sydney-vsr-…
3ae773b 
…table-staff-view

merged branches and getting all vsrs backend progress
@sydneyzhang18
getting all vsrs backend progress
2e45730
@sydneyzhang18
cleaning up for pr
44ee56d
benjaminJohnson2204
benjaminJohnson2204 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@benjaminJohnson2204 benjaminJohnson2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I integrated the frontend with the backend and made some minor CSS touch-ups to match the design, looks good overall. Great work!

Syu125
Syu125 approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@Syu125 Syu125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! I just made a very minor change to get the font to show up for the two buttons.

SamvritSrinath
SamvritSrinath approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@SamvritSrinath SamvritSrinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Stress tested with different names, repeat IDs, as well as repeat names and seems to all be ordered correctly. Special Characters for all fields also work as well.

@benjaminJohnson2204 benjaminJohnson2204 merged commit b53d7d7 into main Mar 4, 2024
4 checks passed
@benjaminJohnson2204 benjaminJohnson2204 deleted the sydney-vsr-table-staff-view branch March 4, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamvritSrinath SamvritSrinath SamvritSrinath approved these changes

@benjaminJohnson2204 benjaminJohnson2204 benjaminJohnson2204 approved these changes

@Syu125 Syu125 Syu125 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VSR Table View for Staff
6 participants
@sydneyzhang18 @Syu125 @benjaminJohnson2204 @SamvritSrinath @2s2e @yotzkim