Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sophia/vsr review page #42

Merged
merged 22 commits into from
May 27, 2024

Conversation

Syu125
Copy link
Contributor

@Syu125 Syu125 commented May 9, 2024

Tracking Info

Resolves #38

Changes

  • Created review page for VSR Form
  • Connected review page with other parts of the form

Testing

  • Filled out the entire VSR form and made sure that the responses were reflected on the review page
  • Checked that the "Edit Section" buttons directed the user back to the correct sections
  • Reviewed the filled out VSR and made sure that the the VSR is submitted successfully.

Confirmation of Change

  • Fill out the VSR
  • When you click "Review" on the third page, you will be directed to the review page
  • To jump back to a section, click the corresponding "Edit Section" button
  • Once you're done reviewing your form, click Submit and VSR should submit properly

Copy link
Collaborator

@benjaminJohnson2204 benjaminJohnson2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I fixed a few minor styling issues (e.g. for the tablet and mobile versions), great job overall! Especially with scrolling to a section when a user edits it.

@benjaminJohnson2204 benjaminJohnson2204 removed the request for review from holychickencow May 15, 2024 19:13
@benjaminJohnson2204 benjaminJohnson2204 removed the request for review from yotzkim May 27, 2024 21:22
@benjaminJohnson2204 benjaminJohnson2204 merged commit 107c387 into main May 27, 2024
4 checks passed
@benjaminJohnson2204 benjaminJohnson2204 deleted the feature/sophia/vsr-review-page branch May 27, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSR Review Page for Veterans
2 participants