Skip to content

Commit

Permalink
Bump deps and fix new lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
justinyaodu committed Jan 17, 2023
1 parent cda1d0e commit 2f38e46
Show file tree
Hide file tree
Showing 8 changed files with 2,974 additions and 3,242 deletions.
2 changes: 2 additions & 0 deletions components/BigCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,5 @@ export default function BigCard({
</Card>
);
}

BigCard.defaultProps = { colorHover: undefined, sized: undefined };
8 changes: 8 additions & 0 deletions components/Gallery.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,17 @@ import { ImageKey } from "../images";
import CustomImage from "./CustomImage";
import RatioImage from "./RatioImage";

// Incorrectly detected as prop types, but these are actually array elements, so
// it doesn't make sense to give default values.
/* eslint-disable react/require-default-props */
/* eslint-disable react/no-unused-prop-types */
export interface LayoutSpec {
imageKey?: ImageKey;
width?: number;
aspectRatio?: [number, number];
}
/* eslint-enable react/require-default-props */
/* eslint-enable react/no-unused-prop-types */

export interface GalleryProps {
children?: React.ReactNode;
Expand Down Expand Up @@ -70,3 +76,5 @@ export default function Gallery({
</>
);
}

Gallery.defaultProps = { children: false, className: undefined, reverseOnSmallScreens: undefined };
2 changes: 2 additions & 0 deletions components/Hero.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,5 @@ export default function Hero({ imageKey, children }: HeroProps) {
</div>
);
}

Hero.defaultProps = { children: undefined };
2 changes: 2 additions & 0 deletions components/PageTitle.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ export default function PageTitle({ title }: PageTitleProps) {
</Head>
);
}

PageTitle.defaultProps = { title: undefined };
4 changes: 2 additions & 2 deletions components/ProfileCardGroup.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Row from "react-bootstrap/Row";
export interface ProfileCardGroupProps {
title?: string;
profiles: React.ReactNode[];
width: 3 | 4;
width?: 3 | 4;
}

export default function ProfileCardGroup({ title, profiles, width }: ProfileCardGroupProps) {
Expand Down Expand Up @@ -39,4 +39,4 @@ export default function ProfileCardGroup({ title, profiles, width }: ProfileCard
);
}

ProfileCardGroup.defaultProps = { width: 4 };
ProfileCardGroup.defaultProps = { title: undefined, width: 4 };
Loading

0 comments on commit 2f38e46

Please sign in to comment.