-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sponge platform #59
base: master
Are you sure you want to change the base?
Sponge platform #59
Conversation
Getting the ball rolling, followed bukkit impl as a guide
Most is pulled from bukkitCommands and modified!
The caveat is that we always return success (for now)
fix typo
One small caveat SpongeCommandManager has a method commented out due to some type erasure issues. Updated javadocs in some areas.
settings.gradle.kts
Outdated
@@ -21,7 +22,7 @@ listOf( | |||
includeProject(name, folder) | |||
} | |||
|
|||
include("test-module") | |||
include("Spawn-Protection") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you don't include this.
minecraft/mc-common/build.gradle.kts
Outdated
id("cmds.library-conventions") | ||
} | ||
|
||
repositories {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed.
minecraft/sponge/build.gradle.kts
Outdated
} | ||
|
||
repositories { | ||
maven { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace with maven("https://repo.spongepowered.org/maven")
.
* {@inheritDoc} | ||
*/ | ||
@Override | ||
public void execute(@NotNull Runnable command) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget the final
.
remove unused plugin and repo block in gradle condense sponge maven repo make Runnable final
No description provided.