Adding compatibility check in GeoDA for neural network-based classifiers #2514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update addresses the compatibility issue between GeoDA and Scikit-learn's RandomForestClassifier. I added a check in the GeoDA constructor to ensure that it only runs with classifiers that include input_shape and channels_first attributes. When an incompatible model, like RandomForestClassifier, is used, the code now raises a ValueError.
Fixes #2493
Type of change
Please check all relevant options.
Testing
I added a unit test (test_geoda_incompatibility.py) that verifies the compatibility check by raising a ValueError when GeoDA is applied to a RandomForestClassifier. This test passed successfully.
Test Configuration:
Checklist