Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added E2E lexical card tests for paragraphs and signup card #17159

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

SimonBackx
Copy link
Contributor

@SimonBackx SimonBackx force-pushed the lexical-card-e2e-tests branch 2 times, most recently from 31882fc to a162252 Compare June 29, 2023 08:25
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 57.28% and project coverage change: -0.07 ⚠️

Comparison is base (d0bea0d) 71.75% compared to head (9d10f02) 71.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17159      +/-   ##
==========================================
- Coverage   71.75%   71.69%   -0.07%     
==========================================
  Files        1829     1833       +4     
  Lines      116021   116265     +244     
  Branches    17261    17275      +14     
==========================================
+ Hits        83252    83356     +104     
- Misses      31652    31788     +136     
- Partials     1117     1121       +4     
Flag Coverage Δ
e2e-tests 66.53% <42.50%> (-0.11%) ⬇️
unit-tests 63.52% <38.07%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ices/collections/BookshelfCollectionsRepository.js 0.00% <0.00%> (ø)
ghost/core/core/server/models/collection.js 60.25% <60.25%> (ø)
ghost/collections/src/Collection.ts 100.00% <100.00%> (ø)
ghost/collections/src/CollectionsService.ts 100.00% <100.00%> (ø)
ghost/collections/src/RepositoryUniqueChecker.ts 100.00% <100.00%> (ø)
...ost/core/core/server/services/collections/index.js 100.00% <100.00%> (ø)
...t/core/core/server/services/collections/service.js 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SimonBackx SimonBackx merged commit c41694f into TryGhost:main Jun 29, 2023
@SimonBackx SimonBackx deleted the lexical-card-e2e-tests branch June 29, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant