Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed signup card in post plaintext and email preheader #17163

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

SimonBackx
Copy link
Contributor

fixes https://github.com/TryGhost/Team/issues/3542

The signup card text was included in the post plaintext/excerpt and email preheader

fixes https://github.com/TryGhost/Team/issues/3542

The signup card text was included in the post plaintext/excerpt and email preheader
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (e6dbc0b) 71.72% compared to head (193c177) 71.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17163      +/-   ##
==========================================
- Coverage   71.72%   71.69%   -0.04%     
==========================================
  Files        1833     1833              
  Lines      116267   116269       +2     
  Branches    17283    17278       -5     
==========================================
- Hits        83393    83356      -37     
- Misses      31754    31787      +33     
- Partials     1120     1126       +6     
Flag Coverage Δ
e2e-tests 66.48% <ø> (-0.02%) ⬇️
unit-tests 63.52% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ghost/html-to-plaintext/lib/html-to-plaintext.js 97.05% <100.00%> (+0.05%) ⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SimonBackx SimonBackx merged commit c904245 into TryGhost:main Jun 29, 2023
17 checks passed
@SimonBackx SimonBackx deleted the fixed-signup-preheader branch June 29, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant