Added migration and schema change for posts_meta.hide_title_and_feature_image
#17187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
migration
|
It looks like this PR contains a migration 👀 General requirements
Schema changes
Data changes
|
kevinansfield
force-pushed
the
add-hide-title-and-feature-image-property
branch
2 times, most recently
from
40996cd
to
5740a12
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #17187 +/- ##
==========================================
+ Coverage 71.70% 71.76% +0.05%
==========================================
Files 1836 1836
Lines 116454 116462 +8
Branches 17275 17298 +23
==========================================
+ Hits 83508 83579 +71
+ Misses 31829 31762 -67
- Partials 1117 1121 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…ure_image` closes TryGhost/Product#3550 We want to allow an option to hide the title and feature image on a per-page basis, to do that we need somewhere to store the setting value. The existing `posts_meta` table is the simplest candidate, especially as this is a single setting and we don't have a desire to introduce many such settings. - added migration that adds the `hide_title_and_feature_image` column to the `posts_meta` table with a `boolean` data type and a default value of `false` (matches behaviour of all existing pages) - updated schema file for initial database creation
kevinansfield
force-pushed
the
add-hide-title-and-feature-image-property
branch
from
5740a12
to
ceae2e2
Compare
|
Full API implementation on top of this data change can be seen in 59d5223 |
ronaldlangeveld
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/TryGhost/Team/issues/3550
We want to allow an option to hide the title and feature image on a per-page basis, to do that we need somewhere to store the setting value. The existing
posts_metatable is the simplest candidate, especially as this is a single setting and we don't have a desire to introduce many such settings.hide_title_and_feature_imagecolumn to theposts_metatable with abooleandata type and a default value offalse(matches behaviour of all existing pages)