Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped packages #17196

Merged
merged 7 commits into from
Jul 4, 2023
Merged

Bumped packages #17196

merged 7 commits into from
Jul 4, 2023

Conversation

ronaldlangeveld
Copy link
Member

@ronaldlangeveld ronaldlangeveld commented Jul 4, 2023

refs https://github.com/TryGhost/Team/issues/3544

  • Bumps required packages to fix an issue.

🤖 Generated by Copilot at 5fb728e

Updated @tryghost/helpers dependency to fix some helper issues. This improved the accuracy and security of the {{reading_time}} and {{encode}} helpers in Ghost themes.

@ronaldlangeveld ronaldlangeveld marked this pull request as ready for review July 4, 2023 09:38
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (1b33634) 71.67% compared to head (e5866a5) 71.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17196      +/-   ##
==========================================
+ Coverage   71.67%   71.73%   +0.06%     
==========================================
  Files        1836     1836              
  Lines      116454   116454              
  Branches    17273    17293      +20     
==========================================
+ Hits        83468    83541      +73     
+ Misses      31866    31792      -74     
- Partials     1120     1121       +1     
Flag Coverage Δ
e2e-tests 66.47% <ø> (-0.04%) ⬇️
unit-tests 63.68% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ronaldlangeveld ronaldlangeveld enabled auto-merge (squash) July 4, 2023 10:47
daniellockyer and others added 6 commits July 4, 2023 12:59
refs TryGhost/Toolbox#609

- this rewrites the CI workflow to include a pre-test step which will
  download and cache dependencies, and will only run tests when the
  associated code changes
- this provides a huge improvement over the existing setup, and will
  save us a lot of time in CI
- if we push to a branch, and open a PR, we'll get duplicate executions
- this fixes that by adding the same check we have elsewhere in the
  workflow
@ronaldlangeveld ronaldlangeveld merged commit 539550b into main Jul 4, 2023
@ronaldlangeveld ronaldlangeveld deleted the fixed-base64-limit branch July 4, 2023 11:14
ronaldlangeveld added a commit that referenced this pull request Jul 4, 2023
refs TryGhost/Product#3544

- Bumps required packages to fix an issue on posts that still contains base64 images.

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 5fb728e</samp>

Updated `@tryghost/helpers` dependency to fix some helper issues. This
improved the accuracy and security of the `{{reading_time}}` and
`{{encode}}` helpers in Ghost themes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants