Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Istanbul timezone #20172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

muratcorlu
Copy link

@muratcorlu muratcorlu commented May 8, 2024

Turkish time zone is set to GMT+31 since 20182. Current label indicates old state.

I'm not sure if I need to create a migration file for this change.

Footnotes

  1. https://en.wikipedia.org/wiki/List_of_tz_database_time_zones

  2. https://en.wikipedia.org/wiki/Time_in_Turkey

Turkish time zone is set to GMT+3 since 2017. Current label indicates old state.
@github-actions github-actions bot added the affects:admin Anything relating to Ghost Admin label May 8, 2024
@vikaspotluri123
Copy link
Member

The file looks like test fixtures, I think you need to update https://github.com/TryGhost/SDK/tree/main/packages/timezone-data

@muratcorlu
Copy link
Author

Oh, ok. I couldn't notice that. Then I'll close this and open a PR on SDK project. Thank you @vikaspotluri123

@muratcorlu muratcorlu closed this May 8, 2024
@muratcorlu
Copy link
Author

Done: TryGhost/SDK#495

@muratcorlu
Copy link
Author

Actually, updating this fixture file stille makes sense after fixing the SDK, right?

@muratcorlu muratcorlu reopened this May 8, 2024
@muratcorlu muratcorlu changed the title Uptime Istanbul timezone Update Istanbul timezone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants