Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call recalcBlockCounts on the client #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't call recalcBlockCounts on the client #29

wants to merge 1 commit into from

Commits on Sep 17, 2024

  1. Don't call recalcBlockCounts on the client 

    This logic is expensive, and we only need to know if there may be any special colliding blocks in the section.

Before this change, ClientboundLevelChunkWithLightPacket was the top contributor to frame time spikes, after this change it's nowhere near the top of the profile. Specifically, the recalc logic was taking upwards of 80% of the processing time for this packet, the simplified check only takes <5%.
    @jpenilla
    jpenilla committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    72274c6 View commit details
    Browse the repository at this point in the history