Replace Gibbs inner loop with recursion #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were doing work that was already done by the caller of initialstep.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2464 +/- ##
==========================================
+ Coverage 84.88% 85.01% +0.13%
==========================================
Files 21 21
Lines 1581 1582 +1
==========================================
+ Hits 1342 1345 +3
+ Misses 239 237 -2 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12771943133Details
💛 - Coveralls |
|
The discrepancy in test suite runtimes between 1.10 and 1.11 is now gone, as expected. |
* Variable naming, destructuring * Tuple -> Vec
penelopeysm
approved these changes
Jan 14, 2025
|
I supposeeeee we should wait for CI to run again, because I don't know if my renaming broke something, but otherwise happy |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2445
This seems to help with the type inference regression in Julia v1.11. #2445 should be fixed anyway in v1.11.3, but never hurts to help the type inference machinery, let the compiler unroll the loop if it feels like it.
Also made the same change in
initialstep, for consistency, and to neatly ensure thatstatesis always a tuple. Also, in the process, removed some initialisation of the varinfo ininitialstep, that was repeating work done in https://github.com/TuringLang/DynamicPPL.jl/blob/e673b69210e85b60199f2ccd8165226cb03cf040/src/sampler.jl#L113.