Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dark theme #509

Merged

Conversation

jitendravjh
Copy link
Contributor

Copy link
Contributor

Preview the changes: https://turinglang.org/docs/pr-previews/509
Please avoid using the search feature and navigation bar in PR previews!

@shravanngoswamii
Copy link
Member

Hello @penelopeysm, version check workflow is failing here, can you please have a look at it?

@penelopeysm
Copy link
Member

penelopeysm commented Aug 22, 2024

@shravanngoswamii I'm fairly sure it's because the PR is being made from a fork, the action runs fine on #510.

Will edit the action to handle this case more gracefully, but it's safe to ignore it for now!

@shravanngoswamii
Copy link
Member

Will edit the action to handle this case more gracefully, but it's safe to ignore it for now!

Thank You, @penelopeysm!

@shravanngoswamii
Copy link
Member

shravanngoswamii commented Aug 23, 2024

@jitendravjh I think the background colour of this breadcrumb should be same as main bg-color!

image

@jitendravjh
Copy link
Contributor Author

Thank you for the feedback! I'll update the breadcrumb background color.

@shravanngoswamii shravanngoswamii merged commit f30f0ee into TuringLang:master Sep 15, 2024
4 checks passed
github-actions bot added a commit that referenced this pull request Sep 15, 2024
@jitendravjh jitendravjh deleted the jitendravjh/dark-theme branch September 17, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants