-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implementation of #86 #87
Conversation
I'd suggest to keep this PR as simple as possible, and just focus on the Weave commands + converting all notebooks to jmd here (I guess one might be able to do this in a semi-automated fashion using Weave?). Then we should just run them locally, using the Weave scripts, before merging the PR (SciMLTutorials used a manual build process for years before switching to CI some months ago). |
I would maybe go even further and not even touch the existing environment nor update the tutorials in this PR, since I guess there is a lot to update and it might become confusing quite quickly. |
100% agree with this! (Though I did make a tiny change to the VI tutorial, but not planning on making any more!) BUT I also realize that because I'm moving files around, etc. the review process is going to be horrible. Maybe it would be a good idea (this is what you're also getting at, right?) to do it in several PRs:
Also, all of the above should probably be merged into a Thoughts? |
Yes, exactly, that's mainly what I had in mind.
That's a good idea! Let's just make sure that every change to master before the branch is merged, goes into the staging branch as well. So, yes, I think this sounds like a good plan 👍 |
Great! |
How's this @devmotion ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, I added some minor comments.
In general, I think the results = "hidden"
statements are applied a bit inconsistently here - shouldn't we remove all the semicolons that are used to suppress output currently if we add them? Or just not add them for now?
Ref #86 and its discussion. This PR is WIP for converting TuringTutorials.jl into a similar structure as https://github.com/SciML/SciMLTutorials.jl.
TODOs