Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto generated from templates by gromit #6728

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

konrad-sol
Copy link
Contributor

@konrad-sol konrad-sol commented Nov 27, 2024

User description

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

PR Type

enhancement, configuration changes


Description

  • Commented out the concurrency section in the release workflow to potentially address issues with concurrent runs.
  • Updated step IDs for Docker metadata actions to ensure consistency and avoid conflicts.
  • Introduced a new step to dynamically choose the test code branch based on the GitHub event type (release, pull request, or push).
  • Removed steps related to uploading Playwright Test Reports to S3 and sharing the report link, possibly to streamline the workflow or due to changes in reporting strategy.

Changes walkthrough 📝

Relevant files
Enhancement
release.yml
Update release workflow with new branch handling and metadata steps

.github/workflows/release.yml

  • Commented out the concurrency section.
  • Updated various step IDs for metadata actions.
  • Added a new step for choosing the test code branch based on the event
    type.
  • Removed steps for uploading Playwright Test Report to S3 and sharing
    the report link.
  • +46/-30 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @konrad-sol konrad-sol requested a review from a team as a code owner November 27, 2024 13:23
    @buger
    Copy link
    Member

    buger commented Nov 27, 2024

    A JIRA Issue ID is missing from your branch name, PR title and PR description! 🦄

    Your branch: releng/master

    Your PR title: Auto generated from templates by gromit

    Your PR description:

    Description

    Related Issue

    Motivation and Context

    How This Has Been Tested

    Screenshots (if appropriate)

    Types of changes

    • Bug fix (non-breaking change which fixes an issue)
    • New feature (non-breaking change which adds functionality)
    • Breaking change (fix or feature that would cause existing functionality to change)
    • Refactoring or add test (improvements in base code or adds test coverage to functionality)

    Checklist

    • I ensured that the documentation is up to date
    • I explained why this PR updates go.mod in detail with reasoning why it's required
    • I would like a code coverage CI quality gate exception and have explained why

    If this is your first time contributing to this repository - welcome!


    Please refer to jira-lint to get started.

    Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

    Valid sample branch names:

    ‣ feature/shiny-new-feature--mojo-10'
    ‣ 'chore/changelogUpdate_mojo-123'
    ‣ 'bugfix/fix-some-strange-bug_GAL-2345'

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Concurrency Handling
    The concurrency section has been commented out. This change might lead to issues with concurrent runs not being handled as expected, potentially causing conflicts or resource contention.

    ID Consistency
    Updated step IDs for Docker metadata actions to ensure consistency. This change is crucial to avoid conflicts but should be thoroughly tested to ensure that it does not affect the expected workflow behavior.

    Dynamic Branch Selection
    Introduced a new step to dynamically choose the test code branch based on the GitHub event type. This addition is significant and should be reviewed for correctness in branch selection logic to prevent potential errors in test execution.

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Contributor

    API Changes

    no api changes detected

    @buger buger force-pushed the releng/master branch 4 times, most recently from 5097a6d to 53365cc Compare November 28, 2024 09:39
    @alephnull alephnull force-pushed the releng/master branch 7 times, most recently from dbe67d4 to 8e354bf Compare November 29, 2024 09:54
    @@ -1,17 +1,17 @@
    # Generated by: gromit policy

    FROM debian:bookworm-slim as DEB
    FROM debian:bookworm-slim AS deb
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Halleluyah 🏆

    Copy link

    sonarqubecloud bot commented Dec 3, 2024

    Quality Gate Failed Quality Gate failed

    Failed conditions
    0.0% Coverage on New Code (required ≥ 80%)

    See analysis details on SonarQube Cloud

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants