-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-13716]change external oas ref to a local copy in gateway #6758
base: master
Are you sure you want to change the base?
Conversation
Let's make that PR title a 💯 shall we? 💪 Your PR title and story title look slightly different. Just checking in to know if it was intentional!
Check out this guide to learn more about PR best-practices. |
Swagger Changes
_ __ __
_| |_ _ / _|/ _| between swagger-prev.yml
+ one list entry added:
+ one list entry added:
+ one list entry added:
+ one list entry added:
- one list entry removed:
- one list entry removed:
- one list entry removed:
- one list entry removed:
± value change
± value change
/ _' | | | | |_| |_ and swagger-current.yml
\__,_|\__, |_| |_| returned six differences
paths./tyk/apis/oas.get.responses.200.content.application/json.schema.items.allOf
paths./tyk/apis/oas.post.requestBody.content.application/json.schema.allOf
paths./tyk/apis/oas/import.post.requestBody.content.application/json.schema.$ref
paths./tyk/apis/oas/{apiID}.get.responses.200.content.application/json.schema.allOf
paths./tyk/apis/oas/{apiID}.patch.requestBody.content.application/json.schema.$ref
paths./tyk/apis/oas/{apiID}.put.requestBody.content.application/json.schema.allOf
| (_| | |_| | _| _| |
API Changes no api changes detected |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Quality Gate failedFailed conditions |
User description
TT-13716
TT-13716
The external ref https://raw.githubusercontent.com/OAI/OpenAPI-Specification/main/schemas/v3.0/schema.json returns error 404.
To fix this we have changed from an external ref to a local schema that is saved in the gateway. This will help us have control of the schema.
We have changed https://raw.githubusercontent.com/OAI/OpenAPI-Specification/main/schemas/v3.0/schema.json to https://raw.githubusercontent.com/TykTechnologies/tyk/refs/heads/master/apidef/oas/schema/3.0.json
PR Type
Bug fix
Description
.redocly.lint-ignore.yaml
to use the new local schema URL.swagger.yml
to replace all instances of the external schema reference with the local schema URL across multiple API paths.Changes walkthrough 📝
.redocly.lint-ignore.yaml
Replace external OpenAPI schema reference with local schema URL
.redocly.lint-ignore.yaml
URL.
swagger.yml
Update OpenAPI schema references in API definitions
swagger.yml
URL with a local schema URL.
schema.