-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements for v0.1 #46
Conversation
…override them (if needed)
…or LOX, enabled the removal of validation rules
…er, since not all child services need to be overridden, only the desired ones
…er to use Langium-Typir also in non-LSP projects
…ation of validations in Typir-Langium as well
…, might be useful in the future, improves readability already now
… a fix which is part of Langium 3.3 now
…es are not new but are already supported, but typechecking by TypeScript didn't show warnings due to 'unknown'
…rvice to make the implementation exchangable
…rovide the Typir services via an "typir"-property/service within the Langium services
…h a lower-case letter
…emoving the hand-written type checking some commits ago as well)
…ady initialized, before a new one is created #44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this big lot of improvements @JohannesMeierSE. They look fine to me, I just have a few detail remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements, looks fine to me!
Beyond improving comments, refactorings, polishing and so on, these notable improvements are done in this PR:
Hints for the review