Introduce yang-lsp-settings-schema.json #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON Schema for the yang.settings file is specified to allow for various IDE plugins to take the LSP version corresponding schema and associate them to the yang.settings for ease of editing and review. It is also updated that yang.settings is a JSON with Comments filetype since it was already supporting comments. This change addresses the issue TypeFox#233 Signed-off-by: Siddharth Sharma <[email protected]>
|
There is possibly more work required for distribution aspects for various IDE LSP Clients implementations to provide associations to |
|
@esmasth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON Schema for the yang.settings file is specified to allow for various IDE plugins to take the LSP version corresponding schema and associate them to the yang.settings for ease of editing and review.
It is also updated that yang.settings is a JSON with Comments filetype since it was already supporting comments.
This change addresses the issue #233