Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad-import-yang-version handling #237

Merged
merged 3 commits into from
Mar 22, 2024

Commits on Mar 16, 2024

  1. Fix bad-import-yang-version handling

    It is allowed to import YANG 1.1 modules from YANG 1.0 when importing
    without revision-date. bad-import-yang-version was flagged even when
    a YANG 1.1 module was imported by YANG 1.0 module without specifying
    revision-date and is now fixed.
    
    This fix addresses TypeFox#228
    
    Signed-off-by: Siddharth Sharma <[email protected]>
    esmasth committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    e38d96d View commit details
    Browse the repository at this point in the history
  2. Refine build documenation and settings

    Added build settings for vscode
    
    Signed-off-by: Siddharth Sharma <[email protected]>
    esmasth committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    8760d7e View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Improve import statement revision-date check

    substatementsOfType does not return null and hence only empty needs
    to be checked. Also changed the order of checks to improve performance.
    
    Signed-off-by: Siddharth Sharma <[email protected]>
    esmasth committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    f135076 View commit details
    Browse the repository at this point in the history