Fix function-namespaces on variables

Resolves #2478

CHANGELOG.md

@@ -4,6 +4,10 @@
 
 -   Added a new `--sitemapBaseUrl` option. When specified, TypeDoc will generate a `sitemap.xml` in your output folder that describes the site, #2480.
 
+## Bug Fixes
+
+-   Fixed an issue where a namespace would not be created for merged function-namespaces which are declared as variables, #2478.
+
 ## v0.25.7 (2024-01-08)
 
 ### Bug Fixes

src/lib/converter/symbols.ts

@@ -1043,9 +1043,10 @@ function convertVariableAsFunction(
         );
     }
 
-    convertFunctionProperties(context.withScope(reflection), symbol, type);
-
-    return ts.SymbolFlags.Property | ts.SymbolFlags.NamespaceModule;
+    return (
+        convertFunctionProperties(context.withScope(reflection), symbol, type) |
+        ts.SymbolFlags.Property
+    );
 }
 
 function convertFunctionProperties(
@@ -1070,6 +1071,8 @@ function convertFunctionProperties(
 
         return ts.SymbolFlags.NamespaceModule;
     }
+
+    return ts.SymbolFlags.None;
 }
 
 function convertAccessor(

src/test/converter2/issues/gh2478.ts

@@ -0,0 +1,10 @@
+declare const test: (options?: test.Options) => void;
+
+declare namespace test {
+    interface Options {
+        a: string;
+        b: number;
+    }
+}
+
+export { test };

src/test/issues.c2.test.ts

@@ -1361,4 +1361,15 @@ describe("Issue Tests", () => {
 
         equal(project.children[0].children?.map((c) => c.name), ["Options"]);
     });
+
+    it("Creates a separate namespace for `declare namespace` case with variables #2478", () => {
+        const project = convert();
+
+        equal(project.children?.map((c) => [c.name, c.kind]), [
+            ["test", ReflectionKind.Namespace],
+            ["test", ReflectionKind.Function],
+        ]);
+
+        equal(project.children[0].children?.map((c) => c.name), ["Options"]);
+    });
 });