Fix validation of @link tags to symbols outside documentation

Resolves #2681

CHANGELOG.md

@@ -7,6 +7,7 @@
 ### Bug Fixes
 
 -   Fixed an issue where links in packages mode would be resolved incorrectly, #2680.
+-   `@link` tags to symbols which are not included in the documentation will produce invalid link warnings again, #2681.
 -   Fixed handling of `@param` tags on comments attached to function callback parameters, #2683.
 
 ## v0.26.6 (2024-08-18)

src/lib/validation/links.ts

@@ -4,6 +4,7 @@ import {
     type Comment,
     type CommentDisplayPart,
     type ProjectReflection,
+    ReflectionSymbolId,
 } from "../models";
 import type { Logger } from "../utils";
 
@@ -16,7 +17,7 @@ function getBrokenPartLinks(parts: readonly CommentDisplayPart[]) {
         if (
             part.kind === "inline-tag" &&
             linkTags.includes(part.tag) &&
-            !part.target
+            (!part.target || part.target instanceof ReflectionSymbolId)
         ) {
             links.push(part.text.trim());
         }

src/test/converter2/issues/gh2681.ts

@@ -0,0 +1,4 @@
+/**
+ * {@link Generator}
+ */
+export const bug = 123;

src/test/issues.c2.test.ts

@@ -1671,6 +1671,16 @@ describe("Issue Tests", () => {
         logger.expectNoOtherMessages();
     });
 
+    it("#2681 reports warnings on @link tags which resolve to a type not included in the documentation", () => {
+        const project = convert();
+        app.options.setValue("validation", false);
+        app.options.setValue("validation", { invalidLink: true });
+        app.validate(project);
+        logger.expectMessage(
+            'warn: Failed to resolve link to "Generator" in comment for bug',
+        );
+    });
+
     it("#2683 supports @param on parameters with functions", () => {
         const project = convert();
         const action = querySig(project, "action");