My courses #34
Merged
My courses #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added CourseView, CourseFilter (in-progress), and CourseList (list of CourseViews) * added filter dropdown * reformatted information to table view * transitioned grid to using flexbox for versatility
* Displaying all user-course & course info
* TODO * Store filter changes into local storage and read from ls for default * Touchup css (make it prettier) * Use actual loading overlay component * Use actual error component
Modified styling Added a tag for each ListItem
MikeDrewitt
requested changes
Jul 28, 2021
Fixed accidental deletion of font fixed pacing error for error page Fixed error bug
MikeDrewitt
requested changes
Jul 28, 2021
MikeDrewitt
reviewed
Jul 29, 2021
MikeDrewitt
approved these changes
Jul 29, 2021
|
I'll leave this up until tomorrow if anyone else wants to take a look. But otherwise I think this looks g2g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
closes #15
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.Further comments
I added a small tag to the left of every course to easily differentiate them and add some color. I used an npm package licensed under MIT license to make hashes of each course code. I think it adds a nice visual flair, but if it needs to be removed then that's completely fine.
I didn't add this to this pull request, but there's an argument to be made to be able to toggle between rows and cards (which given the current implementation would not be difficult to do). Possibly redundant but thought I would at least throw the idea out there.
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...